Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to update texts #230

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

PaulGuerre
Copy link

This pull request allows users to update all the texts, when password is cleared, when caps lock is active, when password is verified and when password is wrong.

@emersion
Copy link
Member

emersion commented Mar 8, 2022

What's the use-case for this?

@PaulGuerre
Copy link
Author

What's the use-case for this?

Just if you want to change the swaylock basic texts. In my case, I don't like the texts without maj : "clear", "wrong". And now, you can have "Clear", "Wrong", or others "key-words" as "Error", or every words.

@emersion
Copy link
Member

emersion commented Mar 8, 2022

This doesn't strike me as a very useful feature.

@PaulGuerre
Copy link
Author

This doesn't strike me as a very useful feature.

I know that some persons (including me) don't like basic texts, especially without first capital letter. That may be used for others languages too.

@emersion
Copy link
Member

emersion commented Mar 8, 2022

I'd be open to capitalize the text FWIW. The lowercase versions aren't a deliberate decision IIRC. Or maybe it's to mimic i3lock? What does i3lock do here?

For translations, I think something like #151 would be a better approach.

@PaulGuerre
Copy link
Author

I'd be open to capitalize the text FWIW. The lowercase versions aren't a deliberate decision IIRC. Or maybe it's to mimic i3lock? What does i3lock do here?

For translations, I think something like #151 would be a better approach.

Ok np, so for thoses like #212 , they may check this repo

@Xyene
Copy link
Member

Xyene commented Mar 12, 2022

@NiciTheNici
Copy link

NiciTheNici commented Nov 21, 2022

I think this would be a useful feature for further customization. Is there any chance of this being merged anytime soon in the future?

@NiciTheNici NiciTheNici mentioned this pull request Nov 21, 2022
@Elu43
Copy link

Elu43 commented Nov 12, 2023

It would be great for other languages. Is there any other way to change English ?
Thank you for your work

@savente93
Copy link

Would also really appreciate this as I'd like to show the battery percentage on the lock screen so I can check it when my laptop is charging without having to unlock it every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants