Add support for OpenBSD / make wordexp optional #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- like done in swaywm/swaylock#325, provide an alternative for swayidle configuration file lookup - and provide a handrolled config line parser for 'timeout' commands, using strspn(), strchr() and asprintf() - the latter is in recent POSIX so move _POSIX_C_SOURCE 200809L definition within #if HAVE_WORDEXP - OpenBSD doesn't (and won't) have support for systemd/logind, so only care about timeout commands
backports/adapted from swaywm/sway@1d62d6bf wordexp() still used for config parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like done in swaywm/swaylock#325, replace
wordexp()usage by handrolled C equivalents - i've been testing it working file with this in~.config/swayidle/config:and it behaves as expected.
The handrolled line parser might be improved, but i've tested it with lines having extra spaces between keywords or trailing spaces.
Feedback welcome !