Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Only give a titlebar height for normal borders #8101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lanodan
Copy link

@lanodan lanodan commented Apr 3, 2024

Closes: #7409

@lanodan
Copy link
Author

lanodan commented Apr 3, 2024

Note that while this respects the documented configuration, interaction with windows having other border settings is quite a mess.
screen

I guess sway should be forcing borders on childs of non-toplevel container with multiple childs.

Probably what's attempted there but failing because a workspace always has a container (and/or title height being queried in a lot of other places):

static void arrange_children(enum sway_container_layout layout, list_t *children,
struct sway_container *active, struct wlr_scene_tree *content,
int width, int height, int gaps) {
int title_bar_height = container_titlebar_height();
if (layout == L_TABBED) {
struct sway_container *first = children->length == 1 ?
((struct sway_container *)children->items[0]) : NULL;
if (config->hide_lone_tab && first && first->view &&
first->current.border != B_NORMAL) {
title_bar_height = 0;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hide the titlebar
1 participant