Hiding lone titlebar scenegraph #8076
Conversation
There was a problem hiding this comment.
Thanks @svalaskevicius ! This is working for me, so I guess we could close #7889 in favor of this one.
svalaskevicius
force-pushed
the
hiding-lone-titlebar-scenegraph
branch
from
ecc2e16
to
07ec101
Compare
to hide the title bar on workspaces with one child, fix swaywm#7409
|
I found a little bug: when I open a first transparent windows (my terminal, kitty, in the current case), it doesn't have a title bar, which is expected. Then, I open a second one, and I get 2 side-by-side windows, both with titlebar, which is still expected. When I close one of the 2, the title bar of the lone window disappear, which is still the correct behavior. But the space taken by the titlebar of the left window doesn't get its background back, and I have a black rectangle in place of my wallpaper there, on the top left corner of my screen. It's minor, as the windows itself is behaving as expected, and only the transparent background is not updated, but we might be missing something here. I guess it's not kitty's fault, because this issues did not appear on #7889. |
this is a WIP PR, for comments and hopefully others joining in taking this feature onwards :)
the render.c file was removed and the logic is switching to the scenegraph based implementation.
during my brief testing this seems to have worked, but the testing was limited as I got stumbled on another issue of the master branch - waybar was not showing after I create windows (#8075) so I reverted to the previous version for now.
a step towards resolving #8072 - hopefully :)