Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: tablet: add tablet tool scroll support #8058

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

louis-goyard
Copy link

@louis-goyard louis-goyard commented Mar 11, 2024

This aims at implementing #5854.

For tablets that don't have finger features and no wheels, sliders, etc., it can be annoying to scroll on applications that are not specifically designed for tablet use in minds, when you just want to use the tablet instead of the mouse for everyday life.

This is my first attempt at implementing tablet tool scroll, and a way to open the discussion for the tablet tool scroll API. Sorry if things are still in a draft state, I will edit things according to your comments.

This MR doesn't support (for now at least) scroll button lock. I don't know if this is something that I should try to add or not for now.

Related MRs:

Implementation explanations:

For now at least, don't treat the tablet tool scroll as a compositor shortcuts for example. As this is a non-discrete scroll, this would be difficult to implement window rotating with it for example.

I wasn't sure about the seatop_down / seatop_default thing, so I basically handed up copying what handle_tablet_tool_tip did. Please tell me if this is wrong.

Also, there is a specific point I'm struggling with about the wlr_pointer_axis_event.pointer element, I will create a comment below to expand on it.

Pipeline is failing because of libinput API changes required to make tablet tool scroll work. I'm not sure about how to handle this from a CI point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant