input: Propagate modifiers to clients with only pointer focus #7927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Jan 23, 2024
danieldg
force-pushed
the
propagate-modifiers
branch
from
0f879e3
to
5242a93
Compare
When focus_follows_mouse is off, it is possible to hover and/or scroll windows without giving them keyboard focus. However, attempts to use Ctrl+scroll on such clients will not work correctly because the keyboard modifiers are not available. This patch propagates modifier state to the client with pointer focus before sending axis events. This depends on https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4523. https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/259 discusses permitting this behavior at the protocol level.
danieldg
force-pushed
the
propagate-modifiers
branch
from
5242a93
to
1c12934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When focus_follows_mouse is off, it is possible to hover and/or scroll windows without giving them keyboard focus. However, attempts to use Ctrl+scroll on such clients will not work correctly because the keyboard modifiers are not available. This patch propagates modifier state to the client with pointer focus
when it gains focus and when the state changesbefore sending axis events.https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/259 discusses permitting this behavior at the protocol level.