Skip to content

Commit

Permalink
Wrap picture element with a paragraph tag (#4)
Browse files Browse the repository at this point in the history
Closes #3
  • Loading branch information
svenluijten committed Aug 1, 2023
1 parent 6505199 commit c89c8ca
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 11 deletions.
3 changes: 2 additions & 1 deletion src/Event/ImageMediaQueryListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ public function processDocument(DocumentParsedEvent $event): void

AttributeHelper::removeFromNode($lastImage, ['media']);

$paragraph->replaceWith($picture);
$paragraph->detachChildren();
$paragraph->appendChild($picture);
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-dark.jpg" /><img src="/example-light.jpg" alt="image two" /></picture>
<p><picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-dark.jpg" /><img src="/example-light.jpg" alt="image two" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-one-dark.jpg" /><img src="/example-one-light.jpg" alt="image one light" /></picture><picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-two-dark.jpg" /><img src="/example-two-light.jpg" alt="image two light" /></picture>
<p><picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-one-dark.jpg" /><img src="/example-one-light.jpg" alt="image one light" /></picture></p>
<p><picture class="media-query-picture"><source media="(prefers-color-scheme: dark)" srcset="/example-two-dark.jpg" /><img src="/example-two-light.jpg" alt="image two light" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(max-width: 600px)" srcset="/600.jpg" /><img src="/default.jpg" alt="default" /></picture>
<p><picture class="media-query-picture"><source media="(max-width: 600px)" srcset="/600.jpg" /><img src="/default.jpg" alt="default" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/1000.jpg" /><img src="/default.jpg" alt="default" /></picture>
<p><picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/1000.jpg" /><img src="/default.jpg" alt="default" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(max-width: 1000px)" srcset="/1000.jpg" /><source media="(max-width: 800px)" srcset="/800.jpg" /><source media="(max-width: 560px)" srcset="/560.jpg" /><img src="/default.jpg" alt="default" /></picture>
<p><picture class="media-query-picture"><source media="(max-width: 1000px)" srcset="/1000.jpg" /><source media="(max-width: 800px)" srcset="/800.jpg" /><source media="(max-width: 560px)" srcset="/560.jpg" /><img src="/default.jpg" alt="default" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/1000.jpg" /><source media="(min-width: 800px)" srcset="/800.jpg" /><source media="(min-width: 560px)" srcset="/560.jpg" /><img src="/default.jpg" alt="default" /></picture>
<p><picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/1000.jpg" /><source media="(min-width: 800px)" srcset="/800.jpg" /><source media="(min-width: 560px)" srcset="/560.jpg" /><img src="/default.jpg" alt="default" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/large.jpg" /><img src="/medium.jpg" alt="medium" /></picture>
<p><picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/large.jpg" /><img src="/medium.jpg" alt="medium" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/large.jpg" type="image/jpeg" /><img src="/medium.jpg" alt="medium" /></picture>
<p><picture class="media-query-picture"><source media="(min-width: 1000px)" srcset="/large.jpg" type="image/jpeg" /><img src="/medium.jpg" alt="medium" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><source media="(min-width: 1200px)" srcset="/1200.jpg" /><source media="(min-width: 800px)" srcset="/800.jpg" /><source media="(min-width: 480px)" srcset="/480.jpg" /><img src="/default.jpg" alt="The actual image and the alt that will be used" /></picture>
<p><picture class="media-query-picture"><source media="(min-width: 1200px)" srcset="/1200.jpg" /><source media="(min-width: 800px)" srcset="/800.jpg" /><source media="(min-width: 480px)" srcset="/480.jpg" /><img src="/default.jpg" alt="The actual image and the alt that will be used" /></picture></p>
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<picture class="media-query-picture"><img src="/large.jpg" alt="large" /></picture>
<p><picture class="media-query-picture"><img src="/large.jpg" alt="large" /></picture></p>

0 comments on commit c89c8ca

Please sign in to comment.