Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic utility for making any class reactive #11504

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open

feat: generic utility for making any class reactive #11504

wants to merge 71 commits into from

Commits on Jun 1, 2024

  1. a new take on reactivity package

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    f076bbc View commit details
    Browse the repository at this point in the history

  2. removed unnecessary as const cast

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    72cb168 View commit details
    Browse the repository at this point in the history

  3. fixed condition of delete in ReactiveSet

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    54e33aa View commit details
    Browse the repository at this point in the history

  4. better describe what mutation_properties does

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    10c8197 View commit details
    Browse the repository at this point in the history

  5. improved types

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c163ec7 View commit details
    Browse the repository at this point in the history

  6. improved jsdocs for interceptors

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    35d9906 View commit details
    Browse the repository at this point in the history

  7. removed map from utils because it wasnt used anymore

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6162079 View commit details
    Browse the repository at this point in the history

  8. removed enforcement of defining interceptors since each mutation_prop… 

    …erty doesnt *require* one
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8da76fa View commit details
    Browse the repository at this point in the history

  9. 1- interceptors can be used for anything now (types) 

    2- removed templated constructor params cause it didn't do anything (types)
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6c4a4b6 View commit details
    Browse the repository at this point in the history

  10. renamed signal to version_signal

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    81d33e3 View commit details
    Browse the repository at this point in the history

  11. added some comments

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ea91192 View commit details
    Browse the repository at this point in the history

  12. again another take on this matter, but this version is not optimized … 

    …at all
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6885f1c View commit details
    Browse the repository at this point in the history

  13. added comments to read_methods_signals and version_signal

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    3dc711d View commit details
    Browse the repository at this point in the history

  14. fixed a bug where if a method didn't take arguments reactivity wouldn… 

    …'t work
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    785e51e View commit details
    Browse the repository at this point in the history

  15. fixed test because logging false after clear for 3 is not fine-graine… 

    …d (because we already got it after delete)
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0df3dcd View commit details
    Browse the repository at this point in the history

  16. initial map support

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2177272 View commit details
    Browse the repository at this point in the history

  17. instead of nested functions used separate function

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    cb8bf44 View commit details
    Browse the repository at this point in the history

  18. added the ability to notify with all params

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    80a73b4 View commit details
    Browse the repository at this point in the history

  19. fixed test

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    eaa3fc2 View commit details
    Browse the repository at this point in the history

  20. used symbol instead of stupid uuid! what was I thinking??

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2ad0a21 View commit details
    Browse the repository at this point in the history

  21. optimized when we create the signals

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    1bfdd60 View commit details
    Browse the repository at this point in the history

  22. added tests regarding handling of values not the set/map

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c6c4f46 View commit details
    Browse the repository at this point in the history

  23. removed size from read properties because it can depend on version si… 

    …gnal and doesn't require its own signal
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    68dfe79 View commit details
    Browse the repository at this point in the history

  24. removed todo comment

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    b7049d8 View commit details
    Browse the repository at this point in the history

  25. improved comments

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    5950d47 View commit details
    Browse the repository at this point in the history

  26. notifying other signals of changes, AFTER the change has actually too… 

    …k effect
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9715aa8 View commit details
    Browse the repository at this point in the history

  27. added fix to work with $inspect rune

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d8bc4c7 View commit details
    Browse the repository at this point in the history

  28. optimized version signal updates

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    58b8c10 View commit details
    Browse the repository at this point in the history

  29. simplified reactivity for map

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    77405de View commit details
    Browse the repository at this point in the history

  30. improved comments and simplified code

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2d12cba View commit details
    Browse the repository at this point in the history

  31. ran build which auto updated index.d.ts

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    dc89f8d View commit details
    Browse the repository at this point in the history

  32. fixed linter issue

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    38a0d5e View commit details
    Browse the repository at this point in the history

  33. made read_properties optional

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    662a48d View commit details
    Browse the repository at this point in the history

  34. simplify and improve types

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    cfc219e View commit details
    Browse the repository at this point in the history

  35. improved utility for reactivity package so if we wanted to we can exp… 

    …ort stuff from the base proxied class
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    90531c1 View commit details
    Browse the repository at this point in the history

  36. changed reactivity/url to use the new utility, also made it fine-grai… 

    …ned reactive
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    42bf1e9 View commit details
    Browse the repository at this point in the history

  37. renamed notify_read_methods to notify_read_properties

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7ac79e6 View commit details
    Browse the repository at this point in the history

  38. refactored date.js to use the generic make_reactive utility

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0ccda20 View commit details
    Browse the repository at this point in the history

  39. improved comments

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    989f429 View commit details
    Browse the repository at this point in the history

  40. added more tests for searchParams

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0e4239c View commit details
    Browse the repository at this point in the history

  41. removed sending the constructor params to getters!

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    12ddf38 View commit details
    Browse the repository at this point in the history

  42. made url more fine-grained

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    416a68e View commit details
    Browse the repository at this point in the history

  43. fixed where updating the search wouldn't keep the new order of how th… 

    …ey are added
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    45025be View commit details
    Browse the repository at this point in the history

  44. added more tests for url

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    8ddf061 View commit details
    Browse the repository at this point in the history

  45. ran build and updated generated index.d.ts

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7f3634e View commit details
    Browse the repository at this point in the history

  46. fixed copy pasta errors

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    82f62e3 View commit details
    Browse the repository at this point in the history

  47. added fine-grained test for url

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    f79784a View commit details
    Browse the repository at this point in the history

  48. removed searchParams on url from write_properties

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ab13b7f View commit details
    Browse the repository at this point in the history

  49. used version_signal's initial value to determine if it has already ch… 

    …anged within a single changeset or not
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c9a9881 View commit details
    Browse the repository at this point in the history

  50. added more tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    376297e View commit details
    Browse the repository at this point in the history

  51. improved and simplified console.log/debug/etc behavior of Reactive[So… 

    …mething] classes
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    968d0d6 View commit details
    Browse the repository at this point in the history

  52. renamed NOTIFY_WITH_ALL_PARAMS to NOTIFY_WITH_ALL_REGISTERED_PARAMS

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    353184c View commit details
    Browse the repository at this point in the history

  53. used // comments so that internal stuff won't show in the index.d.ts

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    7f2b7b0 View commit details
    Browse the repository at this point in the history

  54. simplified get_signal_for_function and added more tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6734775 View commit details
    Browse the repository at this point in the history

  55. renamed variables and created config so interceptors can be extended … 

    …easily
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    68b1423 View commit details
    Browse the repository at this point in the history

  56. made set and map more fine-grained and improved tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    bcd2927 View commit details
    Browse the repository at this point in the history

  57. more streamlined behavior: only returning true will increment the ver… 

    …sion signal now
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    dc80bf3 View commit details
    Browse the repository at this point in the history

  58. initial attempt to make date fine-grained

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    df4ae4d View commit details
    Browse the repository at this point in the history

  59. used the new utility to create a fine-grained ReactiveDate

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    b5067af View commit details
    Browse the repository at this point in the history

  60. simplified tmp date creation for notify_datetime_changes

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4885739 View commit details
    Browse the repository at this point in the history

  61. added tests for date

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    045f8a2 View commit details
    Browse the repository at this point in the history

  62. renamed test name

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    37fafab View commit details
    Browse the repository at this point in the history

  63. fixed url tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2e8225a View commit details
    Browse the repository at this point in the history

  64. improved date tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    11f2508 View commit details
    Browse the repository at this point in the history

  65. added comments describing why we use get_registered_params before not… 

    …ifying read methods
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    65c0064 View commit details
    Browse the repository at this point in the history

  66. improved tests

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    c48f6ff View commit details
    Browse the repository at this point in the history

  67. moved modified_date_to_compare out of function to prevent creating … 

    …a new instance on each change
    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    cf2f76f View commit details
    Browse the repository at this point in the history

  68. simplified interceptors for date

    @FoHoOV
    godzylinux authored and FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d59a51a View commit details
    Browse the repository at this point in the history

  69. improved date tests

    @FoHoOV
    FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    474155b View commit details
    Browse the repository at this point in the history

  70. improved reactivity for search-params

    @FoHoOV
    FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2459461 View commit details
    Browse the repository at this point in the history

  71. fixed url to work with node18

    @FoHoOV
    FoHoOV committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    d3fd750 View commit details
    Browse the repository at this point in the history