test, don't merge: hmc support #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangphcn
force-pushed
the
s390-base
branch
2 times, most recently
from
53246e8
to
58e6f29
Compare
Signed-off-by: Peng Hui Jiang <jiangph@cn.ibm.com>
|
@jiangphcn release generated in golang-zhmcclient here https://github.com/zhmcclient/golang-zhmcclient/releases/tag/v0.3.0 to support the new function. |
|
thanks @jiangphcn this is really good! Would you be made the PR ready for the next release? |
|
thanks so much @rootfs for your encourage, as always. Yes, I will try my best to make it be ready for next release. |
jichenjc
reviewed
Mar 4, 2024
| type PowerHMC struct{} | ||
|
|
||
| func (a *PowerHMC) GetName() string { | ||
| return "hmc" | ||
| func (r *PowerHMC) GetName() string { |
There was a problem hiding this comment.
should we think about zhmc as it's for z/s390x ?
|
|
||
| func (r *PowerHMC) GetHMCManager() *zhmcclient.ZhmcManager { | ||
| if hmcManager == nil { | ||
| endpoint := os.Getenv("HMC_ENDPOINT") |
There was a problem hiding this comment.
not sure we should add a PREFIX such as Z_ so it will be easier for other platform to know it's for z only?
| } | ||
| energy, _, err := hmcManager.GetEnergyDetailsforLPAR(lparURI, props) | ||
| if err != nil { | ||
| klog.V(1).Infof("Error getting energy data: %v", err.Message) |
|
|
||
| func (r *PowerHMC) GetNodeComponentsEnergy() map[int]source.NodeComponentsEnergy { | ||
| pkgEnergy, _ := r.GetLiveEnergyFromLpar() | ||
| pkgEnergy = pkgEnergy * 3 |
There was a problem hiding this comment.
maybe we can write some info here about why we need this *3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.