Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n cleanup #7325

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

I18n cleanup #7325

wants to merge 2 commits into from

Conversation

SamMousa
Copy link
Contributor

The idea of this PR is to clean up the i18n code a bit:

  1. Instead of importing the full mutable object everywhere we just import a reader getString()
  2. For new translations we export a registration function instead of writing to the object in multiple places.

The goal of this is to create some abstraction instead of having a global, largely untyped, object being changed everywhere in the code.
I'd like feedback on point 2 before I apply it to all translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant