Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null=True for DNSDomain and DNSRecords #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peterbppb
Copy link

dns_ips slack module assumes domains and records cannot be null so it tries to strip them here: https://github.com/surface-security/surface/blob/main/surface/dns_ips/slack.py#L74-83

We should either remove null=True to avoid this issue or filter for that in the slack processor.

I think removing null=True from these model fields makes sense as I do not think we have any need for records/domains without a name.

@peterbppb peterbppb requested a review from a team as a code owner June 28, 2023 11:11
@peterbppb peterbppb requested review from DDuarte and fopina June 28, 2023 11:11
Copy link
Contributor

@gsilvapt gsilvapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of removing these attributes in both models, they are not appropriate for their data types.
When releasing this, we might need to add a note for all forks take into account this change (they will need to provide a default, most likely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants