Remove null=True for DNSDomain and DNSRecords #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dns_ips slack module assumes domains and records cannot be null so it tries to strip them here: https://github.com/surface-security/surface/blob/main/surface/dns_ips/slack.py#L74-83
We should either remove null=True to avoid this issue or filter for that in the slack processor.
I think removing null=True from these model fields makes sense as I do not think we have any need for records/domains without a name.