Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump django-stubs from 1.12.0 to 4.2.0 #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2023

Bumps django-stubs from 1.12.0 to 4.2.0.

Commits
  • 87f48b3 Version 4.2.0 release (django-stubs, django-stubs-ext) (#1458)
  • c659fc2 Run CI with Django 4.2 and declare support in package metadata (#1452)
  • feccb05 Rename BaseModelMeta to TypedModelMeta and document it (#1456)
  • 3e81d11 CI: Stop testing with Python 3.7 (#1453)
  • fe430fa Bump requests from 2.28.2 to 2.29.0 (#1457)
  • 01a12ef CI: Add Django 4.2 to typecheck and update other Django versions (#1455)
  • 4ab0159 Syndication Feed items do not need to be Model instances (#1444)
  • b15d602 Add stubs for new async model methods from 4.2 (#1443)
  • 2969651 Allow any reverse relation using ForeignObjectRel to be type checked (#1451)
  • 687e67e Add django.utils.http.content_disposition_header. (#1448)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [django-stubs](https://github.com/typeddjango/django-stubs) from 1.12.0 to 4.2.0.
- [Release notes](https://github.com/typeddjango/django-stubs/releases)
- [Commits](https://github.com/typeddjango/django-stubs/compare/django-stubs@1.12.0...4.2.0)

---
updated-dependencies:
- dependency-name: django-stubs
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner May 15, 2023 02:59
@dependabot dependabot bot requested review from ppb007 and mariandppb May 15, 2023 02:59
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels May 15, 2023
@gsilvapt
Copy link
Contributor

gsilvapt commented May 17, 2023

image

🤨

After taking a look at this, I don't think we're using django-stubs at all. My search only reveals the requirement in the dev file. Perhaps we can drop this dependency, @fopina @DDuarte @bogdanoniga ? Removing the dependency still passes all tests 🤷‍♂️

@fopina
Copy link
Contributor

fopina commented May 23, 2023

I think @DDuarte added this one when he was trying mypy but not sure if we're still using it (mypy)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 5, 2023

A newer version of django-stubs exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants