Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added a way to programmatically open the find elements dialog #243

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

- Added a way to programmatically open the find elements dialog #243

wants to merge 1 commit into from

Conversation

bjsi
Copy link
Member

@bjsi bjsi commented Oct 20, 2020

NativeMethod.TSMMain_FindElements.ExecuteOnMainThread((char)x, (char)y, (char)z);

The underlying search method is a generic function that SM uses to search its various registries.
I am not entirely sure what the parameters represent yet. Though I believe the y parameter represents the search target (registry?)
The parameters for this method added to the ElementWdw are copied from the IDR disassembly for the TSMMain.MIFindElementsClick function.

Let me know if you want me to investigate further / add / change anything etc.

@alexis- alexis- self-requested a review November 5, 2020 12:38
@alexis-
Copy link
Member

alexis- commented Nov 5, 2020

I don't think I can accept that PR:

  • If I merge a specific application of a function, then when its generic implementation becomes available I will need to deprecate the old (specific) version
  • The function bugs on the first call (?)

@alexis- alexis- added enhancement New feature or request rejected this has been reviewed and rejected by core dev. sma-api SMA interface API labels Nov 5, 2020
@alexis- alexis- added this to the x.y.z (Future release) milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rejected this has been reviewed and rejected by core dev. sma-api SMA interface API
Development

Successfully merging this pull request may close these issues.

None yet

2 participants