Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCLang: tidy duplicated error message #6299

Conversation

JordanHendersonMusic
Copy link
Contributor

@JordanHendersonMusic JordanHendersonMusic commented May 6, 2024

Purpose and Motivation

This is uncontroversial and can be quickly reviewed.

Cannot have more than 255 arguments to a function, but the message was printed twice. This removes that duplication.
Some code to test, it should only show one error message after this PR.

{| foo , foo0, foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, foo9, foo10, foo11, foo12, foo13, foo14, foo15, foo16, foo17, foo18, foo19, foo20, foo21, foo22, foo23, foo24, foo25, foo26, foo27, foo28, foo29, foo30, foo31, foo32, foo33, foo34, foo35, foo36, foo37, foo38, foo39, foo40, foo41, foo42, foo43, foo44, foo45, foo46, foo47, foo48, foo49, foo50, foo51, foo52, foo53, foo54, foo55, foo56, foo57, foo58, foo59, foo60, foo61, foo62, foo63, foo64, foo65, foo66, foo67, foo68, foo69, foo70, foo71, foo72, foo73, foo74, foo75, foo76, foo77, foo78, foo79, foo80, foo81, foo82, foo83, foo84, foo85, foo86, foo87, foo88, foo89, foo90, foo91, foo92, foo93, foo94, foo95, foo96, foo97, foo98, foo99, foo100, foo101, foo102, foo103, foo104, foo105, foo106, foo107, foo108, foo109, foo110, foo111, foo112, foo113, foo114, foo115, foo116, foo117, foo118, foo119, foo120, foo121, foo122, foo123, foo124, foo125, foo126, foo127, foo128, foo129, foo130, foo131, foo132, foo133, foo134, foo135, foo136, foo137, foo138, foo139, foo140, foo141, foo142, foo143, foo144, foo145, foo146, foo147, foo148, foo149, foo150, foo151, foo152, foo153, foo154, foo155, foo156, foo157, foo158, foo159, foo160, foo161, foo162, foo163, foo164, foo165, foo166, foo167, foo168, foo169, foo170, foo171, foo172, foo173, foo174, foo175, foo176, foo177, foo178, foo179, foo180, foo181, foo182, foo183, foo184, foo185, foo186, foo187, foo188, foo189, foo190, foo191, foo192, foo193, foo194, foo195, foo196, foo197, foo198, foo199, foo200, foo201, foo202, foo203, foo204, foo205, foo206, foo207, foo208, foo209, foo210, foo211, foo212, foo213, foo214, foo215, foo216, foo217, foo218, foo219, foo220, foo221, foo222, foo223, foo224, foo225, foo226, foo227, foo228, foo229, foo230, foo231, foo232, foo233, foo234, foo235, foo236, foo237, foo238, foo239, foo240, foo241, foo242, foo243, foo244, foo245, foo246, foo247, foo248, foo249, foo250, foo251, foo252, foo253, foo254| 
	
}

Closes #5592

Types of changes

  • An error message was duplicated, fixes that.

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

Cannot have more than 255 arguments to a function, but the message was printed twice. This removes that duplication.

Closes supercollider#5592
Copy link
Contributor

@smoge smoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks uncontroversial. Good eye.

@JordanHendersonMusic JordanHendersonMusic added the comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" label May 7, 2024
@telephon
Copy link
Member

telephon commented May 7, 2024

even if it is uncontroversial, someone needs to run one compile and check if it breaks nothing. (I can't, because for me the build is stil broken)

@smoge
Copy link
Contributor

smoge commented May 8, 2024

even if it is uncontroversial, someone needs to run one compile and check if it breaks nothing. (I can't, because for me the build is stil broken)

Unless it's a typo for something else, like checking mVarlist?

I think it was your contribution, Julian @telephon . Maybe you remember if was just repetition, or was checking another aspect?

Mar 29, 2014 6d0f685

(I can build and run on linux if needed)

@telephon
Copy link
Member

telephon commented May 8, 2024

Ah, I don't remember why it seemed necessary at that time. Yes, if you test compile it on linux and see if it works as intenden, it should be fine.

@mtmccrea
Copy link
Member

Ah, I don't remember why it seemed necessary at that time.

Looks like there may have just been some mixup in commit revisions and the change ended up in two commits.

@mtmccrea mtmccrea merged commit 2025c68 into supercollider:develop May 17, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy and paste error in PyrParseNode.cpp>>PyrBlockNode::compile ?
4 participants