Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCDoc: Add subsubsection #6266

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

prko
Copy link
Contributor

@prko prko commented Apr 22, 2024

Purpose and Motivation

This is a revised PR that addresses the relevant part of PR #6254.
Also, it is related to #3843 and #6131.

Some opinions have already been expressed in PRs #6260 and #6263. I am aware that some believe I may be doing things incorrectly. However, I am doing this in order to complete the task of dividing PR #6254.

I plan to keep this PR open for several weeks to gather more feedback on my work.

Types of changes

  • Documentation
  • New feature

To-do list

  • Code is tested
  • All tests are passing
  • Updated documentation
  • This PR is ready for review

added subsubsection (soft-coded)
@JordanHendersonMusic JordanHendersonMusic added the comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help" label Apr 24, 2024
prko added 4 commits May 16, 2024 10:07
- subsubection added
- An error occurred when adding a subsubsection, fixed.
This help document is based on an incorrect implementation, so it has been removed.
add subsubsection
@prko prko changed the title SCDoc improvements: 4. Subsubsection (soft-coded) SCDoc: Add subsubsection May 16, 2024
@prko
Copy link
Contributor Author

prko commented May 16, 2024

See how this works:
Screenshot 2024-05-16 at 10 39 13

@prko prko requested a review from telephon May 16, 2024 01:41
Copy link
Member

@telephon telephon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really separate any changes to the bison parser from the addition in the current issue. So please make separate pull requests.

Sorry for the complication!

@prko
Copy link
Contributor Author

prko commented May 19, 2024

@telephon

OK!

To make it clear what I should do:

Should math and subsubection tags be included when making a PR for updating bison and flex?

@telephon
Copy link
Member

if it is not too much of a hassle, just separate it in a commit of the same pull request. There is another pull request with the same or similar update (#6317).

@prko
Copy link
Contributor Author

prko commented May 19, 2024

Um...

There are other related PRs:
#6260 and #6265, as well as a request: #6304.

context, post...

Simple, but not easy because of the commit history and not knowing if the PR and request will be accepted or not...

@telephon
Copy link
Member

Ok, so leave it, and let's wait for #6317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: SCDoc scdoc syntax, parser, and renderer. for changes to schelp files, use "comp: help"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants