build-system: cmake: added compiler flags for c++17 #6246

doubtfulpalace · 2024-04-03T00:08:45Z

Purpose and Motivation

Fixes #6244 (on my Mac at least).

Types of changes

Bug fix

To-do list

[X ] Code is tested // i.e., builds
[X ] All tests are passing // ctest only. Crash tests are supposed to segfault, right?
[n/a ] Updated documentation
[ X] This PR is ready for review

prko · 2024-04-03T14:03:29Z

Thanks for this. I tested it on MacOS 14.4.1 (M1 max chip) and Ubuntu 22.0.4 (ARM64).
On MacOS14.4.1 I could not build without Supernova and with Supernova.
On Ubuntu 22.0.4 I could build, but there are errors.

I attach all output messages in terminal.

macOS 14.4.1
- sc build error with supernova.txt
- sc build error without supernova.txt
ubuntu 22.04
server does not start.
- sc build success with errors ubuntu 22.04 (arm64).txt
- sc build success with errors ubuntu 22.04 (intel).txt

doubtfulpalace · 2024-04-03T15:27:11Z

sc build error without supernova.txt

At line 40453 of sc.build.error.without.supernova.txt I see this:

/Users/prko/SuperCollider/lang/LangPrimSource/PyrStringPrim.cpp:356:16: error: 
      use of undeclared identifier 'errValueRange'
        return errValueRange; // Handle invalid offset

But neither the PR's copy nor the develop branch's copy of PyrStringPrim.cpp contain the string errValueRange. Have you tried building from a fresh clone of the fork?

prko · 2024-04-04T02:56:33Z

Thank you for your feedback!

It is strange... I thought that I used a clean copy.

I have tested again with a clean copy of the source.
You see what I did in the following text file. There is no PyrStringPrim.cpp, but building SC from the source failed. Building SC from source in macOS and Ubuntu in the last year was successful. strange... Hm.

sc clean build error without supernova mac sonoma.txt

doubtfulpalace · 2024-04-04T04:49:58Z

You don't seem to have the patch. What branch are you on? Make sure you're on the PR branch from my fork: doubtfulpalace:topic/fix-build-with-apple-clang-15

/Users/prko/SuperCollider/external_libraries/boost/boost/container_hash/hash.hpp:131:33: error:
      no template named 'unary_function' in namespace 'std'; did you mean
      '__unary_function'?
        struct hash_base : std::unary_function<T, std::size_t> {};
                           ~~~~~^~~~~~~~~~~~~~
                                __unary_function

smoge · 2024-04-04T07:38:18Z

It is strange... I thought that I used a clean copy.

@prko What branch are you/ Can you do git branch --show-current?

doubtfulpalace · 2024-04-04T14:23:26Z

Updating `boost` fixes one of the two errors, I forget which. Unfortunately, it breaks our build, as some `boost` sources end up in the `libscsynth` target and fail to build. I believe it’s because newer `boost` uses a completely different build system. Fixing that was beyond my rudimentary `cmake` skills. On Apr 4, 2024, at 12:43 AM, smoge ***@***.***> wrote: @doubtfulpalace I think at least some of the errors could be fixed by updating the boost library.

prko · 2024-04-05T02:13:50Z

@smoge

@prko Are you using the 64-bit int branch? There are a lot of warnings about that. Can you do git branch --show-current?

Ehm , I think I do not understand what you mean. Any way in terminal I get this:

(base) prko@prkoMBP2021 build % git branch --show-current
develop
(base) prko@prkoMBP2021 build % cd ..
(base) prko@prkoMBP2021 SuperCollider % git branch --show-current
develop

doubtfulpalace · 2024-04-05T02:25:17Z

The develop branch doesn't have the fix, because the PR hasn't been merged yet. The fix is on topic/fix-build-with-apple-clang-15, which is only in the doubtfulpalace fork.

prko · 2024-04-05T03:26:19Z

@doubtfulpalace
After downloading your branch, I get the followint error:

Last login: Fri Apr  5 11:44:41 on ttys001
(base) prko@prkoMBP2021 build % cmake -G Xcode -DCMAKE_PREFIX_PATH=`brew --prefix qt5`  ..
Warning: Formula qt5 was renamed to qt@5.
Warning: Formula qt5 was renamed to qt@5.
-- The C compiler identification is AppleClang 15.0.0.15000309
-- The CXX compiler identification is AppleClang 15.0.0.15000309
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- SuperCollider Version: 3.14.0-dev
-- Building from  , commit hash is na
-- Please specify the build configuration in the next step
-- Compiling with Qt GUI
-- Performing Test COMPILER_SUPPORTS_CXX17
-- Performing Test COMPILER_SUPPORTS_CXX17 - Success
-- Found Pthreads: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk/usr/lib/libpthread.tbd  
CMake Error at external_libraries/CMakeLists.txt:2 (message):
  It appears you haven't cloned this project's git submodules: please run
  `git submodule update --init --recursive` from the root level of the
  repository.

  For advice on setting up submodules, and also on keeping them updated over
  time, please see this wiki page, and consider saving this link:
  https://github.com/supercollider/supercollider/wiki/git-cheat-sheet#working-with-submodules


-- Configuring incomplete, errors occurred!
(base) prko@prkoMBP2021 build %

Thus, I pasted the text you modified into the corresponding file of the develop branch. Now, I seem to succeed uin building only with boost errors. However, On sonoma, interpreter quits, and on Ubuntu server does not start...

Anyway, thanks for your work! I do not understand the details of the errors. However, I remember @JordanHendersonMusic recently worked with Boost, I do not know if he can fix this bug, but I worry if his implementation of ReplaceRegex should be touched again. #6213

doubtfulpalace · 2024-04-05T04:13:05Z

You have to do what it says:

It appears you haven't cloned this project's git submodules: please run
  `git submodule update --init --recursive` from the root level of the
  repository.

Always the case when first cloning SuperCollider.

The server crash is:

/Users/timwalters/git/forks/supercollider/build/Install/SuperCollider/SuperCollider.app/Contents/MacOS/sclang
dyld[16953]: Library not loaded: @loader_path/../../../../opt/libogg/lib/libogg.0.dylib
  Referenced from: <F851A6D8-9303-3B85-B8E3-7F43E1CF576D> /Users/timwalters/git/forks/supercollider/build/Install/SuperCollider/SuperCollider.app/Contents/Frameworks/libsndfile.1.dylib
  Reason: tried: '/Users/timwalters/git/forks/supercollider/build/Install/SuperCollider/SuperCollider.app/Contents/Frameworks/../../../../opt/libogg/lib/libogg.0.dylib' (no such file), '/usr/local/lib/libogg.0.dylib' (no such file), '/usr/lib/libogg.0.dylib' (no such file, not in dyld cache)

I don't think it has anything to do with this change. The problem is that Cmake incorrectly thinks it has found Vorbis, etc.:

-- Performing Test SNDFILE_HAS_VORBIS
-- Performing Test SNDFILE_HAS_VORBIS - Success
-- Performing Test SNDFILE_HAS_OPUS
-- Performing Test SNDFILE_HAS_OPUS - Success
-- Performing Test SNDFILE_HAS_MPEG
-- Performing Test SNDFILE_HAS_MPEG - Success

which is beyond my ability to fix, at least tonight, and I'm leaving town for a couple of weeks tomorrow.

You could try patching the current release branch and see if that works.

muellmusik · 2024-04-18T08:28:22Z

I was able to build with -DCMAKE_CXX_FLAGS="--std=c++17 -D_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES" which I gather has the same effect as this PR.

Is this the best solution though? In the next c++ standard I assume these features are gone?

doubtfulpalace · 2024-04-18T14:02:17Z

Upgrading to current boost would be better, I think, but doesn’t “just work” as they have changed their build system. I tried incorporating that, but quickly got into the weeds. Someone who knows the build system might have better luck.Tim Walters | The Doubtful Palace | http://doubtfulpalace.comOn Apr 18, 2024, at 1:28 AM, Scott Wilson ***@***.***> wrote: I was able to build with -DCMAKE_CXX_FLAGS="--std=c++17 -D_LIBCPP_ENABLE_CXX17_REMOVED_FEATURES" which I gather has the same effect as this PR. Is this the best solution though? In the next c++ standard I assume these features are gone? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

muellmusik · 2024-04-20T09:39:19Z

@doubtfulpalace I don't know if this is helpful for this issue, and may be stating the obvious, but the README_Boost file notes that some boost files have been patched for SC.

smoge · 2024-04-21T04:47:04Z

At least one function causing problems was deprecated in c++11 and removed in c++17. So some features are already "gone":

https://en.cppreference.com/w/cpp/utility/functional/unary_function

(It's not used in the SC codebase, but older boost versions)

doubtfulpalace · 2024-04-21T05:18:09Z

I'm out of town and can't check or give details, but IIRC the problem with updating boost was that boost builds its libraries with something called "b2", and our build script doesn't use that. I tried modifying the cmake files to do it the new way, but (probably due to my lack of cmake skills) it just made a mess, putting boost library source into the Xcode project, which then wouldn't build.

…

On Apr 20, 2024, at 9:47 PM, smoge ***@***.***> wrote: At least one function causing problems was deprecated in c++11 and removed in c++17. So some features are already "gone": https://en.cppreference.com/w/cpp/utility/functional/unary_function — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

build-system: cmake: added compiler flags for c++17

d55f29f

doubtfulpalace mentioned this pull request Apr 3, 2024

build failure #6244

Closed

mtmccrea mentioned this pull request Apr 28, 2024

build error on macOS 14 (Sonoma) – possibly a boost problem? (BOOST_MPL_AUX_STATIC_CAST) #6224

Open

JordanHendersonMusic added the comp: build CMake build system label May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build-system: cmake: added compiler flags for c++17 #6246

build-system: cmake: added compiler flags for c++17 #6246

doubtfulpalace commented Apr 3, 2024

prko commented Apr 3, 2024 •

edited

doubtfulpalace commented Apr 3, 2024

prko commented Apr 4, 2024

doubtfulpalace commented Apr 4, 2024

smoge commented Apr 4, 2024 •

edited

doubtfulpalace commented Apr 4, 2024 via email •

edited

prko commented Apr 5, 2024

doubtfulpalace commented Apr 5, 2024

prko commented Apr 5, 2024

doubtfulpalace commented Apr 5, 2024

muellmusik commented Apr 18, 2024

doubtfulpalace commented Apr 18, 2024 via email

muellmusik commented Apr 20, 2024

smoge commented Apr 21, 2024 •

edited

doubtfulpalace commented Apr 21, 2024 via email

build-system: cmake: added compiler flags for c++17 #6246

Are you sure you want to change the base?

build-system: cmake: added compiler flags for c++17 #6246

Conversation

doubtfulpalace commented Apr 3, 2024

Purpose and Motivation

Types of changes

To-do list

prko commented Apr 3, 2024 • edited

doubtfulpalace commented Apr 3, 2024

prko commented Apr 4, 2024

doubtfulpalace commented Apr 4, 2024

smoge commented Apr 4, 2024 • edited

doubtfulpalace commented Apr 4, 2024 via email • edited

prko commented Apr 5, 2024

doubtfulpalace commented Apr 5, 2024

prko commented Apr 5, 2024

doubtfulpalace commented Apr 5, 2024

muellmusik commented Apr 18, 2024

doubtfulpalace commented Apr 18, 2024 via email

muellmusik commented Apr 20, 2024

smoge commented Apr 21, 2024 • edited

doubtfulpalace commented Apr 21, 2024 via email

prko commented Apr 3, 2024 •

edited

smoge commented Apr 4, 2024 •

edited

doubtfulpalace commented Apr 4, 2024 via email •

edited

smoge commented Apr 21, 2024 •

edited