Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy and paste error in PyrParseNode.cpp>>PyrBlockNode::compile ? #5592

Closed
rd-- opened this issue Oct 9, 2021 · 0 comments · Fixed by #6299
Closed

Copy and paste error in PyrParseNode.cpp>>PyrBlockNode::compile ? #5592

rd-- opened this issue Oct 9, 2021 · 0 comments · Fixed by #6299
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"

Comments

@rd--
Copy link
Contributor

rd-- commented Oct 9, 2021 •
edited

Reading through this just now is seems the second block here is perhaps meant to check the number of variables (numVars)?

At the moment it's just a copy of the block above?

supercollider/lang/LangSource/PyrParseNode.cpp

Lines 3777 to 3787 in 7af277d

if (numArgs > 255) {
error("Too many arguments in function definition (> 255)\n");
nodePostErrorLine((PyrParseNode*)mArglist->mVarDefs);
compileErrors++;
}
if (numArgs > 255) {
error("Too many arguments in function definition (> 255).\n");
nodePostErrorLine((PyrParseNode*)mArglist->mVarDefs);
compileErrors++;
}

@JordanHendersonMusic JordanHendersonMusic mentioned this issue May 6, 2024
Merged
4 tasks
@JordanHendersonMusic JordanHendersonMusic added the comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library" label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: sclang sclang C++ implementation (primitives, etc.). for changes to class lib use "comp: class library"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SCLang: tidy duplicated error message JordanHendersonMusic/supercollider
2 participants
@rd-- @JordanHendersonMusic