feat: support read timeout for inbound HTTP requests #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyannyacha
force-pushed
the
feat-req-idle-timeout
branch
3 times, most recently
from
82bb293
to
9dcc957
Compare
nyannyacha
changed the title
nyannyacha
force-pushed
the
feat-req-idle-timeout
branch
from
4f606e9
to
6eb5f87
Compare
nyannyacha
force-pushed
the
feat-req-idle-timeout
branch
from
6eb5f87
to
ad65a0d
Compare
laktek
approved these changes
May 13, 2024
|
🎉 This PR is included in version 1.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Description
This PR allows setting a timeout between when the connection is established and when the runtime fully consumes the request body, making it less vulnerable to attacks such as Slowloris.
List of arguments to be created due to the introduction of this PR
--request-read-timeoutflag specifies maximum time in milliseconds that can be waited from when the connection is accepted until the request body is fully read. (disabled by default)