Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Enum.php #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Enum.php #28

wants to merge 1 commit into from

Conversation

shadylplplp
Copy link

修改了Enum.php中的build函数
修改
'id' => is_numeric($val) ? $text : $val,
修改成
'id' => is_string($val) ? $text : $val,

原来的判断写法 与文档administrator/docs/field-type-enum.md有冲突
文档中写
if the key is a string, the key will be saved to the database while the value will be presented to the user.
如果键是字符串,则键将保存到数据库中,而值将呈现给用户。

但当options为
'state'=>[
'title'=>'审核',
'type'=>'enum',
'options'=>array('1'=>'未审核','2'=>'过审核','3'=>'不过审核'),
],
这种情况时 会判断错误 所以更改为is_string()来做判断更为合理

渣渣第一次在github上给开源项目改代码 不知道改的对不对
请summer大佬指点谢谢

修改了Enum.php中的build函数
修改
'id'   => is_numeric($val) ? $text : $val,
修改成
'id'   => is_string($val) ? $text : $val,
原来的判断 与文档administrator/docs/field-type-enum.md有冲突
文档中写
if the key is a string, the key will be saved to the database while the value will be presented to the user.
如果键是字符串,则键将保存到数据库中,而值将呈现给用户。
当options为
'state'=>[
'title'=>'审核',
'type'=>'enum',
'options'=>array('1'=>'未审核','2'=>'过审核','3'=>'不过审核'),
],
这种情况时 会错误判断
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant