Upgrade react-datetime to 3.0.0 #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,6 +80,16 @@ class DatePicker extends React.Component<Props> { | |||
| this.props.onChange(date); | |||
|
|
|||
| this.setShowError(!!this.value && !date); | |||
|
|
|||
| // can be removed when is fixed the following is fixed: | |||
| // https://github.com/arqex/react-datetime/pull/741 | |||
There was a problem hiding this comment.
i guess we can remove the closeOnSelect if we implement it like this 🙂
|
I dont think arqex/react-datetime#741 will ever be fixed, so I would be okay with implementing the workaround for closing the Popover 🙂 |
alexander-schranz
force-pushed
the
feature/react-datetime
branch
from
e3063c0
to
dd0a3d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Upgrade react-datetime to 3.0.0. https://github.com/arqex/react-datetime/blob/master/migrateToV3.md.
There is a problem currently with the 3.0 version as it seems not to close the overlay when choosing the time: arqex/react-datetime#741 (comment)
Why?
New version provide bugfixes and new features.