Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing typos #13

wants to merge 1 commit into from

Conversation

mark2185
Copy link
Contributor

Hey, I was reading through the project to learn the code and corrected a few typos.

Unfortunately, the suffle -> shuffle change is not backwards compatible since the config parsing expects the key suffle, but I don't know how to fix it. Could you take a look?

@sudipghimire533
Copy link
Owner

Hello Luka. Thank you for the time.

I will surely go through the changes but might take few days to sort time out. Until then can you please explain the problem you were unable to fix. If there something I could do to generate idea into you, I will.

Thank and have a good time 😄

@mark2185
Copy link
Contributor Author

The config.json contained ShortcutKeys.suffle, but since I changed all suffle into shuffle, the parser fails because it cannot recognize the suffle entry anymore (it's supposed to be shuffle now) and asks the user if they would like a default generated config file instead.

Since I don't know rust, I was hoping you could fix it.

@sudipghimire533
Copy link
Owner

Hello @mark2185 . I think we can rollback the incompatible changes for now. We can work that out later. Can you change that and we will be good to merge

@mark2185 mark2185 mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants