Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset encryption and update buildscript #96

Open
wants to merge 11 commits into
base: kt-n
Choose a base branch
from

Conversation

X1nto
Copy link
Contributor

@X1nto X1nto commented Jan 27, 2022

It seems like I've messed up encryption with my last PR as seen in #95.

While this PR fixes encryption, I also took the opportunity to update the build script to the newest dependencies and managed to clean it up as well.

Changes:

  • Use Kotlin's copyTo and use functions for InputStream and OutputStream operations.
  • Extract complex build script code to the Util object in buildSrc in order to make it more readable.
  • Update AGP, Kotlin, and AppCompat dependencies.
  • Use ignoreCase param in shouldEncrypt() function instead of making the joined task list string lowercase.

Fixes:

  • Fixed encryption.
  • Fixed/Updated README.md to correctly point to ThemerConstants configuration file.

Verified that encryption works on my machine:

Debug APK Release APK
image image

@X1nto X1nto changed the title Fix asset encryption not working properly Fix asset encryption and update buildscript Feb 7, 2022
@hossain666
Copy link

Getconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants