Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/102 #119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue/102 #119

wants to merge 4 commits into from

Conversation

JJJ
Copy link
Collaborator

@JJJ JJJ commented Oct 26, 2020

See #102

@JJJ
Return false on failure in tcp_cache_set().
5bea1f0 
This change ensures that anyone calling tcp_cache_set() directly in their own custom code has a more reliable idea of whether this method call has failed.
@JJJ
Use local or external TCP cache, but not both.
5e8cbf9 
This commit strictly divides the TCP cache methods to stop storing a local copy of the remote cache when a persistent cache exists elsewhere.

It also adds expirations to the local cache, in the event that the PHP request is allowed to process and hang for longer than the servers have collectively to be checked.
@JJJ
Always check TCP responsiveness (if enabled).
452ddb4 
Even for master. No matter the tries remaining.

If TCP responsiveness is being checked and the connection to master goes down, it will exist in the cache.
@JJJ JJJ linked an issue Oct 26, 2020 that may be closed by this pull request
check_tcp_responsiveness causes [Warning] Aborted connection to db: 'unconnected' user: 'unauthenticated' (This connection closed normally without authentication) after MariaDB 10.4 upgrade #102
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@JJJ