Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Move admin page to React (WIP) #2399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinrobinson
Copy link
Contributor

Who is this PR for?

project leads

What problem does this PR fix?

There's some new configuration that would be well-suited for an admin page that project leads can use. Right now this admin page is written in ERB, so can't use UI components from the rest of the app.

What does this PR do?

Migrated it to a JSON endpoint and React UI. This is just a migration, with minimal changes to the UX now.

Screenshot (if adding a client-side feature)

Checklists

Which features or pages does this PR touch?

  • Admin authorization page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@studentinsights-bot
Copy link

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants