Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote streams #708

Merged
merged 16 commits into from
May 21, 2024
Merged

Add support for remote streams #708

merged 16 commits into from
May 21, 2024

Conversation

fancycode
Copy link
Member

@fancycode fancycode commented Apr 17, 2024

This allows subscribing streams from any proxy (resolves #548). Using a different proxy for subscribing is based on subscribers country and / or bandwidth limits of publisher proxy.

Note: requires Janus 1.1.0 or newer.

@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 9170665910

Details

  • 426 of 2221 (19.18%) changed or added relevant lines in 18 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.1%) to 56.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
janus_client.go 0 2 0.0%
grpc_server.go 7 10 70.0%
publisher_stats_counter.go 52 55 94.55%
server/main.go 0 4 0.0%
api_proxy.go 11 37 29.73%
mcu_janus_stream_selection.go 0 59 0.0%
mcu_janus_remote_subscriber.go 0 63 0.0%
mcu_janus_remote_publisher.go 0 89 0.0%
mcu_proxy.go 279 384 72.66%
mcu_janus_client.go 0 126 0.0%
Files with Coverage Reduction New Missed Lines %
mcu_proxy.go 1 61.08%
grpc_remote_client.go 2 75.57%
mcu_janus.go 12 0.48%
Totals Coverage Status
Change from base Build 9170643784: 2.1%
Covered Lines: 9471
Relevant Lines: 16660

💛 - Coveralls

@fancycode fancycode force-pushed the proxy-features branch 2 times, most recently from 2d81afe to 8c07402 Compare April 18, 2024 10:48
proxy/proxy_remote.go Fixed Show fixed Hide fixed
mcu_janus_publisher.go Fixed Show fixed Hide fixed
@fancycode fancycode force-pushed the proxy-features branch 13 times, most recently from 6381d93 to f58d985 Compare April 25, 2024 14:28
@fancycode fancycode force-pushed the proxy-features branch 5 times, most recently from afbf5eb to 499f41c Compare April 29, 2024 10:52
@fancycode fancycode force-pushed the proxy-features branch 4 times, most recently from 566d8b6 to ae7c498 Compare May 16, 2024 14:28
@fancycode fancycode changed the title Improve proxy features Add support for remote streams May 21, 2024
@fancycode fancycode marked this pull request as ready for review May 21, 2024 07:47
@fancycode fancycode merged commit 2cd3418 into master May 21, 2024
19 checks passed
@fancycode fancycode deleted the proxy-features branch May 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subscribing streams from any proxy
2 participants