libheif: check compatible brands in the ftyp box #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh
force-pushed
the
compatible_brands_2024-04-02
branch
from
e8f7883
to
3840e54
Compare
Keeps the existing heif_check_filetype behaviour since that is public API. Adds a new function to check both the major version and the compatible_brands list.
farindk
reviewed
Apr 16, 2024
farindk
reviewed
Apr 16, 2024
farindk
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the existing
heif_check_filetypebehaviour since that is public API. Adds a new function to check both the major version and the compatible_brands list. Switches the heif-convert example to use that new function.I have put an arbitrary 512 byte limit on how long we expect the
ftypbox could be. That seems reasonable, but could be higher or lower.The goal of this is to support files that are both video and images (sharing data), where the major_brand is something like
mp41butheicis listed in thecompatible_brands[].