-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental gain map support #1121
base: master
Are you sure you want to change the base?
Conversation
DichenZhang1
commented
Feb 2, 2024
This feature is hidden behind the WITH_EXPERIMENTAL_GAIN_MAP compile flag. See https://helpx.adobe.com/camera-raw/using/gain-map.html for an introduction to gain maps. Note that in this change, gain maps are not stored as auxiliary items as proposed by Adobe, but as a hidden input to a new 'tmap' (tone mapped) derived item. An 'altr' (alternatives group) box is also added to tell the decoder that it may show the tone mapped image (preferrably) or the base image as a fall back. The primary item id still points to the base image for backward compatibility.
This feature is hidden behind the WITH_EXPERIMENTAL_GAIN_MAP compile flag. See https://helpx.adobe.com/camera-raw/using/gain-map.html for an introduction to gain maps. Note that in this change, gain maps are not stored as auxiliary items as proposed by Adobe, but as a hidden input to a new 'tmap' (tone mapped) derived item. An 'altr' (alternatives group) box is also added to tell the decoder that it may show the tone mapped image (preferrably) or the base image as a fall back. The primary item id still points to the base image for backward compatibility.
Hi there! Can someone help to review this pull request? This is adding gain map support for HEIC and AVIF images. Thank you! |
Hi there! This change is adding support for encoding and decoding HEIC and AVIF with gain map images. Could anyone help to take a look and provide feedback? Thank you! |
Friendly bumping up again. Thank you! |
Thank you for the contribution. It generally looks good. The |
Is this standardized anywhere? Could you point me to the specification? The Adobe document says:
Does that mean that there is no final spec yet? We can include it as "experimental" anyway, but have to make it very clear that the spec is not finalized yet. Do you have any kind of test program? Maybe a patched |
Sync with main branch
Sync with main branch
Add verification code in heif_enc and heif_info
Hi Dirk, Thank you for looking into this! I've changed the Thank you! |