Only raise a warning, not an error for privileged ports #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-allan
force-pushed
the
rm-privileged-ports-error
branch
from
dfb8687
to
70eb8e0
Compare
On MacOS (and on Linux if using authbind) you don't actually need to use sudo to bind to ports < 1024, so node-foreman does not need to raise an error if that happens. Since we can't detect if this system will or will not require sudo we can just raise a warning. Signed-off-by: Matthew Allan <matt@mattallan.me>
matt-allan
force-pushed
the
rm-privileged-ports-error
branch
from
70eb8e0
to
8b87e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS, on Linux if using
authbind, and maybe other cases I don't know about, you don't actually need to use sudo to bind to ports < 1024. However when I try to bind to port 80, Node Foreman raises an error. If I prevent Node Foreman from throwing an error it works fine.Since we can't detect if this system will or will not require sudo we can just raise a warning instead. We could omit the warning entirely but it might be harder to diagnose the issue if you your system does require sudo?
The use case for me is running a local webserver on port 80 and not having to enter a sudo password every time or unnecessarily elevate permissions.
I've been working around the issue by using a different environment variable to pass the PORT through, but that's pretty confusing for everyone else on the team 馃榿
I'm having trouble finding a reference for the MacOS guidelines; this is the best I could find: https://news.ycombinator.com/item?id=18302380