New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins.tf1: implement authentication #5983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I'm just going to comment on the code. I currently don't have time to check the site and validate your plugin changes, including anything related to authentication and HTTP requests+responses.
There are also tons of linting issues which you'll have to fix. Please have a look at this short guide:
https://streamlink.github.io/developing.html
Also one question since I'm unaware of the account restrictions: the plugin covers multiple sites. Is authentication required for of them?
Thanks for the comments. I'll get through them one by one and fix the necessary issues. As for the current restrictions, tf1.fr contains all channels from their group (TF1, TMC, TFX, LCI, TF1 Séries Films, except TV Breizh.) and some other FAST channels created for their occasions. All of them right now needs to have an IP located in France and a valid account to get access to their streams. |
I've rewrote the plugin based on your recommendations. Last commit should reflect all required changes. |
Co-Authored-By: bastimeyer <mail@bastimeyer.de>
I force-pushed onto your PR branch because I decided to clean up the remaining issues myself and make a couple more changes.
Authentication is only required on
New token with throwaway-account:
Cached token:
Invalid auth data:
Geo-blocked access
|
The cache currently doesn't set an expiration time/date, but it's not really important... Going to merge this now. |
Perfect, thanks for going further in this PR. Interesting, thought they would enforce it everywhere. I consider myself corrected. |
This is wonderful. Which version of streamlink will have this modification, if I may ask? |
|
Thank you. |
I tested few hours ago the beta release from yesterday, works perfectly well not the beta release, the nightly build |
It works wonderfully with liveproxy too. Excellent. |
@octavioj sorry for the off topic but what's the point to use this liveproxy exactly? |
That's not the correct place to talk about this I believe. |
probably not. anyway, good job guys, has been quite a long way but result is outstanding ;) |
Resolves #5379
This PR is aimed to provide authentification basis for the website TF1.fr. A step forward would be to check the user subscriptions, as now certain streams might be pay-per-view, under the TF1MAX subscription plan. The answer is the same as if you're not logged in, will answer "Permission insuffisante".
With recommendations from @bastimeyer earlier on, on issue 5379, I've rewrote the plugin to make sure it suits the standards.