native classes and decorators #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade to latest ember-decorators - use native ember decorators polyfill (until 3.10) - update ember modules API babel plugin - add transform runtime babel plugin
- turn AdapterMixin into CustomRESTAdapter that extends from RESTAdapter - make TwitchAdapter extend from that class - make the adapter's urlFragments and headers objects static - add custom decorators for property descriptors and urlFragments
- remove isStreamlinkMixin - refactor SettingsChannelsRoute
also fix and add tests for DocumentationLinkComponent
also fix class names and hide modals from the QUnit test runner layout
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 88.37% 88.57% +0.19%
==========================================
Files 456 489 +33
Lines 14979 15276 +297
Branches 1317 1350 +33
==========================================
+ Hits 13238 13531 +293
- Misses 1657 1662 +5
+ Partials 84 83 -1 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information and the whole PR is meant for myself, so I can write a checklist and stay motivated.
The goal is to modernize the entire code base and upgrade to the most recent Ember (octane) versions.
Everything pushed here is the continuation of the work started one and a half years ago, but still very much WIP. Lots of stuff has changed since then and rebasing the branch, solving merge conflicts and fixing deprecations is a lot of effort. Ideally, this should be split into upgrading Ember and fixing deprecations, and then rewriting everything, but fixing some deprecations is very tedious with the old syntax.
Checklist
The entire adapter stack needs to be reworked, as noted in the code itself. Ideally this should be done when upgrading to the Twitch helix API.
NotificationService will need proper rewrite (PollingService + NotificationService)
Haven't checked this in the rebase. The infinite-scroll mixin needs to be fixed.
TODO