feat: CEA608/708 parser #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernanr99
changed the title
hernanr99
force-pushed
the
feature/cea-608-708
branch
from
29d221a
to
8945ae1
Compare
Signed-off-by: hernan <hernanr@qualabs.com>
…tputFilter instance Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com>
hernanr99
force-pushed
the
feature/cea-608-708
branch
from
8945ae1
to
a5c9def
Compare
littlespex
requested changes
Feb 27, 2024
Signed-off-by: hernan <hernanr@qualabs.com>
|
One question, do you support the subtitles described in videojs/mux.js#439 ? |
Hey @avelad, do you have a playlists we could test with? Or should we try with the one on that PR? |
Yes, you can use: |
…eature/cea-608-708 Signed-off-by: hernan <hernanr@qualabs.com>
We've tried with that one but it doesn't seem to have a subtitle playlist. Could you provide us another one? Or what specific type of subtitle should we test? |
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com> Signed-off-by: Felipe Young <felipey@qualabs.com> Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: Felipe Young <felipey@qualabs.com> Co-authored-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
…tputFilter instance Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Fernando Cuadro <fernandoc@qualabs.com> Signed-off-by: Felipe Young <felipey@qualabs.com> Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: fernandocQualabs <126795603+fernandocQualabs@users.noreply.github.com> Co-authored-by: Felipe Young <felipey@qualabs.com> Co-authored-by: hernan <hernanr@qualabs.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…module import error (streaming-video-technology-alliance#81) * Remove isArrayBufferView import and create as auxiliary function see: streaming-video-technology-alliance#83 --------- Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Hernán Reyes <99908389+hernanr99@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
…on-media-library into feature/cea-608-708 Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> # Conflicts: # CHANGELOG.md # lib/src/id3/util/utf8.ts
littlespex
merged commit 94744b5
into
streaming-video-technology-alliance:feat/608
1 of 2 checks passed
littlespex
added a commit
that referenced
this pull request
Apr 26, 2024
* Added CEA-608/708 methods Signed-off-by: hernan <hernanr@qualabs.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com> Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've implemented support for the CEA608/708 subtitles standard to our library, expanding its capabilities. In this update, alongside the feature implementation, we've initiated the integration with a basic set of tests.
Requirements Checklist