Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Correct some targets and their rules to prevent unneeded rebuilds. #47

Merged
merged 1 commit into from Feb 23, 2024

Conversation

68420948
Copy link

Without this patch the binaries are linked anew and the manpage gets recreated with every 'make' and 'make install' call, even if no changes to the sources have happened.

@streambinder
Copy link
Owner

Hey, please, fix your commit message to be Conventional Commits compliant :)

@streambinder
Copy link
Owner

Please, create separate PRs for each :) Let's keep this one for the PR about Makefile modifications

@68420948 68420948 changed the title Correct some targets and their rules to prevent unneeded rebuilds. build: Correct some targets and their rules to prevent unneeded rebuilds. Feb 22, 2024
@68420948
Copy link
Author

I've updated the PR's title. Let me know if more is needed.

@streambinder
Copy link
Owner

Unfortunately that's not enough. In order to update the commit message you can use git commit --amend and then git push -f. But please, split the PR in two different ones :)

@68420948
Copy link
Author

Hope this is correct now.

Without this patch the binaries are linked anew and the manpage gets
recreated with every 'make' and 'make install' call, even if no changes
to the sources have happened.
@68420948
Copy link
Author

Next try

@streambinder
Copy link
Owner

Thanks!

@streambinder streambinder merged commit 401cf45 into streambinder:master Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants