Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check return values for chdir and asprintf #44

Merged
merged 2 commits into from Nov 9, 2023
Merged

Check return values for chdir and asprintf #44

merged 2 commits into from Nov 9, 2023

Conversation

uweber
Copy link
Contributor

@uweber uweber commented Nov 7, 2023

No description provided.

@streambinder
Copy link
Owner

As for the other diffs, please, make sure to pass commitlint and codespell checks, thanks! :)

@streambinder
Copy link
Owner

Please, amend the commit message to comply to Conventional Commit and now rebase off d20eec6 👍🏻

@uweber
fix: check for return value of chdir and system
1c40d98 
compiler throws warn_unused_result warnings otherwise

Signed-off-by: Ulrich Weber <ulrich.weber@gmail.com>
@uweber
fix: check for return value of asprintf
e186cf1 
in case of failure, free buffer and log error

Signed-off-by: Ulrich Weber <ulrich.weber@gmail.com>
@streambinder streambinder merged commit 64468ff into streambinder:master Nov 9, 2023
4 checks passed
@streambinder
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uweber @streambinder