Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl 3.0: dont use deprecated functions #43

Merged
merged 1 commit into from Nov 9, 2023

Conversation

uweber
Copy link
Contributor

@uweber uweber commented Nov 7, 2023

EVP_PKEY_get1_RSA, RSA_size and RSA_public_decrypt got deprecated in openssl 3.0, switch to EVP_PKEY_verify_recover

Code change mimics strongswan implementation from: src/libstrongswan/plugins/openssl/openssl_rsa_public_key.c

Also works with openssl 1.1.1n from debian buster

@streambinder
Copy link
Owner

Hi @uweber, thanks for your effort, highly appreciated!
Please, take a look at the minor changes needed to land the changes :)

@uweber
Copy link
Contributor Author

uweber commented Nov 7, 2023

Hi @uweber, thanks for your effort, highly appreciated! Please, take a look at the minor changes needed to land the changes :)

Sorry, I have no idea whats wrong with the commit messages and the codespell error is not caused by me:
074e1ceb src/vpnc.c (Ralph Schmieder 2019-01-09 16:56:07 -0800 3155) /* we should ignore resent pakets here.

@streambinder
Copy link
Owner

So for commitlint rule, just make sure you follow the semantics of Conventional Commits.
codespell rule, on the other hand, checks for mispelled words: in that case, pakets should be packets.

@streambinder
Copy link
Owner

Please, amend the commit message to comply to Conventional Commit and now rebase off d20eec6 👍🏻

EVP_PKEY_get1_RSA, RSA_size and RSA_public_decrypt got
deprecated in openssl 3.0, switch to EVP_PKEY_verify_recover

Code change mimics strongswan implementation from:
src/libstrongswan/plugins/openssl/openssl_rsa_public_key.c

Also works with openssl 1.1.1n from debian buster

Signed-off-by: Ulrich Weber <ulrich.weber@gmail.com>
@streambinder streambinder merged commit 9e83abc into streambinder:master Nov 9, 2023
4 checks passed
@streambinder
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants