Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multistream): relax primary platform requirement #4855

Open
wants to merge 86 commits into
base: master
Choose a base branch
from
Open

feat(multistream): relax primary platform requirement #4855

wants to merge 86 commits into from

Conversation

blackxored
Copy link
Contributor

No description provided.

@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 31, 2024 •
edited

BundleMon

Files updated (1)
Status Path Size Limits
✅ renderer.(hash).js
 6.8MB (+12.36KB +0.18%) -
Unchanged files (3)
Status Path Size Limits
✅ vendors~renderer.(hash).js
 4.69MB -
✅ updater.js
 115.28KB -
✅ guest-api.js
 40.19KB -

Total files change +12.36KB +0.1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@blackxored blackxored force-pushed the feat/multistream-primary-platform-reqs branch from 864776b to ff5bbb0 Compare February 14, 2024 20:09
@blackxored blackxored marked this pull request as ready for review February 15, 2024 18:04
gettinToasty
gettinToasty requested changes Feb 15, 2024
View reviewed changes
app/components-react/sidebar/PlatformIndicator.m.less Show resolved Hide resolved
app/components-react/windows/go-live/DestinationSwitchers.tsx Outdated Show resolved Hide resolved
app/components-react/windows/go-live/DestinationSwitchers.tsx Outdated Show resolved Hide resolved
app/components-react/windows/go-live/DestinationSwitchers.tsx Outdated Show resolved Hide resolved
app/components-react/windows/go-live/DestinationSwitchers.tsx Outdated Show resolved Hide resolved
app/components-react/windows/go-live/dual-output/DualOutputGoLiveSettings.tsx Show resolved Hide resolved
app/components-react/windows/go-live/dual-output/NonUltraDestinationSwitchers.tsx Show resolved Hide resolved
app/services/streaming/streaming-view.ts Outdated Show resolved Hide resolved
@blackxored blackxored force-pushed the feat/multistream-primary-platform-reqs branch from 585d6ec to f393d2c Compare February 16, 2024 18:47
@blackxored
fix(build): react-devtools build folder was ignored
afd2d76
@blackxored
fix(build): only enable dev tools on dev mode
d03e557
@blackxored
feat(multistream): allow disabling primary platform in UI
e0befa9
@blackxored
feat(multistream): don't force primary platform
b3761a3
@blackxored
feat(streaming): disable Go Live button when no dest + views
8b29f7d
@blackxored
feat(streaming): avoid forcing primary platform chat
ee6b28d
@blackxored
feat(streaming): use correct platform name when not streaming to primary
9cceda5
@blackxored
feat(multistreaming): primary chat selector
e656b20
@blackxored
feat(multistreaming): setting primary chat sets primary platform
458a87a
@blackxored
feat(multistreaming): sort platforms alphabetically, no more primary …
390b109 
…platform on top
@blackxored
fix(multistream): avoid showing primary chat switcher when unneeded
580c81b
@blackxored
feat(multistream): only show primary switcher with multiple platforms
f0baf65
@blackxored
fix(multistreaming): ensure one enabled platform persists for now
268bae5
@blackxored
fix(streaming): initial attempt of fixing locked-out state
7b046d3
@blackxored
refactor(streaming): remove unused imports
a1f6d22
@blackxored
feat(multistreaming): set primary chat to last remaining active platf…
00be6ad 
…orm when more were enabled
@blackxored
fix(streaming): attempt to fix store watcher around chatUrl
0a30140
@blackxored
fix(multistream): show primary chat switcher on advanced mode
dcefa70
@blackxored
fix(streaming): disable multistream check for enabling a primary plat…
820031f 
…form when restoring settings
@blackxored
fix(streaming): unlock dual output primary
1b1d8d1
@blackxored
feat(sidebar): new logged in status indicator featuring multiplatform
55a74a0
@blackxored
fix(style): logged in text margin
c1a977d
@blackxored
fix(style): custom destination icon hover
75f9a49
@blackxored
fix(streaming): check to prevent going live w/o destinations
249e78d
@blackxored
fix(style): center platform indicator text
8200b76
@blackxored
feat: remove platform disabled state across
ddbb786
@blackxored
feat(onboarding): auto-select primary platform
46252c8
@blackxored
fix(streaming): Go Live settings were not properly resetting
514ef6a
@blackxored
fix: strict nulls
2f1475e
@blackxored
Merge branch 'master' into feat/multistream-primary-platform-reqs
a62c3fb
@blackxored
fix(chat): TikTok's fake chat refactor
fd0f8fe 
TikTok's fake chat component makes other platform chats unable to load
after switching to Tiktok's chat while live. This simplifies Tiktok's
handling by moving logic to the parent component and not rendering a
`Chat` component at all since we don't need to load an URL or setup
resize event listeners, or any of the other functionality we're aware
of. While the code might not be pretty on the caller, getting rid of
render side effects and unrelated code in the `Chat` component that's
already been found to be buggy should be an improvement overall.
@blackxored blackxored force-pushed the feat/multistream-primary-platform-reqs branch from 7787111 to fd0f8fe Compare April 30, 2024 20:18
@blackxored
Merge branch 'fix/go-live-settings' into feat/multistream-primary-pla…
ff1570d 
…tform-reqs
@blackxored
chore: remove logging statement
69f88f2
@blackxored
Merge branch 'fix/go-live-settings' into feat/multistream-primary-pla…
bc336c4 
…tform-reqs
@blackxored
fix(multistream): platform disabled style after failing to disable
74d15bb
@blackxored
Merge branch 'fix/react-devtools-ignored' into feat/multistream-prima…
07d166e 
…ry-platform-reqs
@blackxored
chore: comment
2a0622a
@blackxored
fix(go-live): missing X icon on Dual Output free
6dec668
@blackxored
fix(main): custom destination icon padding
a54c010
@blackxored
fix(chat): improve condition for Tiktok chat info
b6abba6
@blackxored
fix(go-live): custom destinations aren't really persisted
0e0042c 
Custom destinations aren't really being persisted until we toggle a
platform on or off (which saves settings), or (presumably) when going
live. There's a call to `#save` after switching platforms but no such
call exists for custom destinations.
@blackxored
Merge branch 'fix/custom-destinations-not-saved' into feat/multistrea…
5bc56fd 
…m-primary-platform-reqs
@blackxored
feat: switch primary chat to new platform instead of TikTok
8872c2c
@blackxored
chore: typo and comment
7a755ef
@blackxored
fix(style): size for Instagram icon on platform indicators
a8007db
@blackxored
Merge branch 'master' into feat/multistream-primary-platform-reqs
2107721
@blackxored
fix(style): add margin to Instagram notice
dfdd379
@blackxored
refactor(i18n): move Twitch strings to its own file
92c238e
@blackxored
fix(auth): avoid showing username for Instagram or not logged in
3e2bfe6
@blackxored
fix(instagram): use generic Logout on bottom left
0a7ca70
@blackxored
fix(multistream): temp for multistream with TikTok as primary chat
bd19a40
@blackxored
fix(i18n): generic logout str was not present in en_US anymore
d51d4f9
@blackxored
fix: temp fix for dock if Instagram
76f5cde
@blackxored blackxored force-pushed the feat/multistream-primary-platform-reqs branch from 0965092 to 76f5cde Compare May 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gettinToasty gettinToasty gettinToasty requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@blackxored @gettinToasty