Use optimizer with dual output scenes #4652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selector and set default tab in video tab.
…ut vertical not updating.
…ource selector to correctly display scene item node toggles. Create or assign vertical scene nodes when collection initialized.
…ct info for displays.
…splay, it does not set the second stream. When multistreaming vertical display, attempts to start the stream before the previous one has completed.
…utput in studio mode. Show error messages.
* Toggle dual output when logging in via dual output login prompt. * Unsubscribe from login subscription.
…4616) * Ensure Edit Transform only accepts selections from a single display * Get display for edit transform from click handler. * Call cleanup function on unmount. * Revert previous commit. --------- Co-authored-by: Micheline Wu <69046953+michelinewu@users.noreply.github.com>
* Video fps settings apply to both displays. * Remove async from functions. * Remove promise resolution returns and add video prop to Trovo start stream options.
…4623) * Isolate transformation editor commands to source within one display. WIP: isolate drag on display. WIP: Restore single drag handler. WIP: Drag works. WIP: isolate drag on display. Isolate transformation editor commands to sources within one display. Fix scale and crop editor commands. Highlight source selector row when working with items in vertical display. WIP: Restore single drag handler. WIP: Drag works. * Prevent user from dragging sources outside of canvas in dual output mode. * WIP: calc drag boundary. * Create drag boundaries.
* For dual output scenes, remove both nodes. * Remove unused scenes event. * Add timeouts between events in scenes events tests.
… in advanced output mode.
* WIP: Restores node map on second restart. * WIP: node map loads to state and assigns scene item contexts on load. Source selector not filtering vertical nodes. * Remove unnecessary call to obs to set video context. Context already set when loading scene item attributes. * WIP: source selector state update. * Add mutation to state service for when scene node map is set on load. * Code cleanup and filter source selector nodes by display property. * Fix error when switching scenes and scene collections. * Add default display to node model when adding sources. * Code review fixes. * Add sceneNodeMaps guard clause * Fix tests * Fix guard clause * Remove unnecessary change --------- Co-authored-by: Sean Beyer <sean.beyer@streamlabs.com>
BundleMonFiles updated (2)
Unchanged files (2)
Total files change +9.18KB +0.08% Final result: ✅ View report in BundleMon website ➡️ |
|
i think Dual Output is at a point of stability that we can consider refreshing/rebuilding this PR now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.