Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/url protocol enhancement #4650

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

andycreeth
Copy link
Member

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bundlemon
Copy link

bundlemon bot commented Aug 3, 2023

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
6.78MB (+4.84KB +0.07%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.69MB -
updater.js
115.28KB -
guest-api.js
40.19KB -

Total files change +4.84KB +0.04%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@blackxored blackxored left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps would've preferred the protocol to be implemented in the host service, requiring potentially less changes overall, but hard to tell whether we would be able to track all usages breaking because of the added protocol to the host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants