Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Implicit controller registration selection #4126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drmathias
Copy link
Contributor

Allows configuration for the features which are used when implicitly registering API controllers. This is necessary when registering a new feature on the full node that includes a controller, but not wanting to include it in the full node web API (for example, wanting to provide a seperate API). Also useful for nodes where you want to provide selective access to the API.

Usage

new FullNodeBuilder()
    // ...
    .UseApi(options =>
    {
        options.Include<SmartContractWalletFeature>();
    })
new FullNodeBuilder()
    // ...
    .UseApi(options =>
    {
        options.Exclude<BlockStoreFeature>();
        options.Exclude<ConsensusFeature>();
    })

This doesn't effect explicitly registered controllers.

@codingupastorm
Copy link
Collaborator

Cool, we were looking at doing something similar recently. Requested a couple of reviewers who were looking at this.

Copy link
Contributor

@quantumagi quantumagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a handy addition.

Copy link
Collaborator

@fassadlr fassadlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Stuff!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants