Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for CFBundleVersion handled by environmental variable #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iltumio
Copy link

@iltumio iltumio commented Oct 17, 2020

fixed issue #161 with updated test

@iltumio
Copy link
Author

iltumio commented Oct 17, 2020

related to pull request #162

@stovmascript
Copy link
Owner

Looks good. I'll check it out later today. Could you cherry-pick 9801fba into your other branch (iltumio:issue-161) with the earlier PR (#162) and close this one? Thanks.

@iltumio
Copy link
Author

iltumio commented Nov 6, 2020

@stovmascript both commits are already within this pull request. You can merge this one and close the other with a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants