Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test app: unpin a bunch of deps to fix CI #118

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zackse
Copy link
Contributor

@zackse zackse commented Apr 19, 2024

Problem

CI failures after sqlite 2.0.0 was released

An error occurred while loading ./spec/valid_mime_type_spec.rb. - Did you mean?
                    rspec ./spec/valid_mime_type_middleware_spec.rb

Failure/Error: ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"

LoadError:
  Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? can't activate sqlite3 (~> 1.4), already activated sqlite3-2.0.0-x86_64-linux-gnu. Make sure all dependencies are added to Gemfile.

Here's a diff of the bundle install step with the previously-working case on the left and the broken case on the right:

--- working  2024-04-19 14:29:30
+++ busted  2024-04-19 14:29:30
-Fetching sqlite3 1.7.3 (x86_64-linux)
+Fetching sqlite3 2.0.0 (x86_64-linux-gnu)

Solution

Unpin the ancient versions in the test app's Gemfile. Maybe they should still be pinned, but to newer versions? I don't know.

Also need to wait for rails/rails#51592 to be released, which allows sqlite3 2.0 for ActiveRecord.

@tylerbrewer2
Copy link

Super excited for this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants