Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change relationships hashes to lookup by type:id #97

Open
dr-a-patton opened this issue Jan 20, 2017 · 0 comments
Open

Change relationships hashes to lookup by type:id #97

dr-a-patton opened this issue Jan 20, 2017 · 0 comments

Comments

@dr-a-patton
Copy link
Contributor

Since EG never seems to need to lookup a relationship with just the id, but by (minimally) the type/id pairing. We could change the indexing of the hashes to use type+':'+id as the search key. I'm not certain if this would actually make things any faster (basically trading off string concatenation costs for any increased element isolation and the ability to eliminate the after-search type matching filtering if statement). However, it would make the code slightly more streamlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant