Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all type== id== matching statements out store/relationship.js to relationship/relationship.js #98

Open
dr-a-patton opened this issue Jan 20, 2017 · 0 comments

Comments

@dr-a-patton
Copy link
Contributor

The code is a bit inconsistent about this. Most tests are placed in relationship/relationships.js, but some are explicit to store/relationship.js. Of course, given the assumptions behind the switch to relationship_hashes we're already effectively violating this abstraction for performance reasons. Also, if we implement issue #97 this will probably eliminate most of this need. However, any remaining type== id== tests after that should probably be moved to relationship/relationships.js for general code cleanliness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant