Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multiple Editors Instructions #118

Open
wants to merge 1 commit into
base: 2.0-dev
Choose a base branch
from

Conversation

spreadred
Copy link

Added instructions on how to properly initialize multiple editors on the same page. Proper initialization and usage resolves #117 #110 #31

Added instructions on how to properly initialize multiple editors on the same page. Proper initialization and usage resolves steveathon#117 steveathon#110 steveathon#31
@andrews05
Copy link

Nice instructions, although you don't actually need to use data-role - it just needs to be a unique selector. For instance, you can use id selectors like #toolbar1.

@spreadred
Copy link
Author

spreadred commented May 2, 2017

@andrews05 So set the toolbar ids like: id="toolbar1" and then set toolbarSelectors like this: toolbarSelector: "#toolbar1"?

This didn't work for me, I must be misunderstanding.

@andrews05
Copy link

No that's right, it works for me just like that. Not sure why it wouldn't work for you...

@spreadred
Copy link
Author

On the 2.0dev branch of the code? or the older code base?

@andrews05
Copy link

I'm on the older codebase but the 2.0 branch appears to work the same, just from looking at the code. There's no reference to 'data-role' besides the default value for toolbarSelector.

@PallasDoesCode
Copy link
Contributor

@kaptainkommie My PR that removes instructions like these from the README was recently merged in. Can you update the Getting Started wiki article instead? We should start pointing people to this wiki article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Editors Bad Cursor Placement
3 participants