Rewrite to typescript with puppeteer-cluster + additional options and hooks. #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run snapshots for html/png/jpg at once. Added custom processHtml/Css/Page functions. Custom filename for snapshots.
Passing options to external processors.
Tests are passing.
Fixed tests. Cluster has 5s idle time on end to ensure closed crawling, timeout needed to be prolonged in tests to handle this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was working on this wonderful lib for my company purposes and thought I would share the outcome. It's not perfect rewrite (much work to do that I don't have much time for), but some prooved to be very useful.
Changes in this PR include:
processPageruns twice – before inlining css (if enabled ofc) and before getting html contentMore work should be done here sooner or later. I started to move some code around to make it more clear in some cases, but lot's to do here. Also – other packages should also be updated but I did not have much time for that now.
If you are open to some outside input (I can see lots of PRs are waiting for any approval) I can help you with remaining issues and make this lib even greater 😄