Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename extension to cache files #1570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add filename extension to cache files #1570

wants to merge 1 commit into from

Conversation

concubidated
Copy link
Member

@concubidated concubidated commented Oct 26, 2017

This would implement FR #1476
I will let @shakesoda decide if to kill it or merge it.

@dougshell
Copy link

Is there any utilitarian use to this other than conforming to Windows file naming standards (having file extensions)

If not, this can still likely be merged if it does not cause complications elsewhere.

@concubidated
Copy link
Member Author

only thing I can think of is the old cache would remain, and everything else would recache, not a big deal.

@dougshell
Copy link

dougshell commented Aug 2, 2018

the functional impact of that would be nil.

Is this really just a naming convention issue to adhere to Windows standard of having filename.fileextension

@Scraticus
Copy link
Member

Would this change affect any of the caching/score/stat systems used in 5.1?

@concubidated
Copy link
Member Author

concubidated commented Oct 1, 2021

This would cause the old cache to remain there, and for the system to recache everything. again. Personally I think it should just be closed, as its pretty silly. Nothing would change the score/stats system here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants