Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options.outputStripAnsi #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

55utah
Copy link

@55utah 55utah commented Oct 28, 2021

What I do:
Add new option outputStripAnsi, it can clear output's color and style.
Reason:
Plugin use chalk, when outputTarget is function, it will get unreadable text, someone already asked this question. with outputStripAnsi, outputTarget function can get plain text output.

@55utah
Copy link
Author

55utah commented Oct 28, 2021

I already test it and get success, but I failed to create a test case .. >_< .. sorry.

@shwarcu
Copy link

shwarcu commented Nov 5, 2021

@stephencookdev Hi, could you take a look at these pull requests? Are you still maintaining the project?

@stephencookdev
Copy link
Owner

@stephencookdev Hi, could you take a look at these pull requests? Are you still maintaining the project?

Struggling to stay on top of everything definitely 😴 But this change looks good. Let me take a look this weekend and see about getting this released. Thanks for the PR @55utah! 🙂

@shwarcu
Copy link

shwarcu commented Nov 5, 2021

@stephencookdev thanks for responding! 😊 I was looking at this repo for some time and configured it in the project I work in. I was wondering if you are still present here because I will probably try to contribute and I just didn't want to spend plenty of time preparing a PR and then not be noticed 😅

@55utah
Copy link
Author

55utah commented Nov 16, 2021

@stephencookdev @shwarcu Please take a look. ❤️

@shwarcu
Copy link

shwarcu commented Nov 16, 2021

Looks legit to me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants