Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add neo4j graph sage link generator #1872

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Feature/add neo4j graph sage link generator #1872

wants to merge 18 commits into from

Conversation

m0baxter
Copy link
Contributor

@m0baxter m0baxter commented Feb 17, 2021 •
edited

I have added Neo4jGraphSAGELinkGenerator and Neo4jDirectedGraphSAGELinkGenerator. This also adds code to make the Neo4jGraphSAGENodeGenerator compatible with the CorruptedGenerator.

@codeclimate
Copy link

codeclimate bot commented Feb 17, 2021 •
edited

Code Climate has analyzed commit 49e71ea and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot]
codeclimate bot reviewed Feb 17, 2021
View reviewed changes
stellargraph/connector/neo4j/mapper.py Outdated Show resolved Hide resolved
stellargraph/connector/neo4j/mapper.py Outdated Show resolved Hide resolved
stellargraph/connector/neo4j/mapper.py Outdated Show resolved Hide resolved
@m0baxter m0baxter mentioned this pull request Feb 17, 2021
Open
@huonw
Copy link
Member

huonw commented Feb 21, 2021 •
edited

Thanks @m0baxter , from the description this sounds like a really great addition. Unfortunately, I've got a bit of a crunch with other work and this looks like a significant chunk of code, so I'm not sure when I'll get a chance to review it. (I've set a reminder for next week, so I won't forget about it completely. 😄 )

@m0baxter
Copy link
Contributor Author

Thanks @m0baxter , from the description this sounds like a really great addition. Unfortunately, I've got a bit of a crunch with other work and this looks like a significant chunk of code, so I'm not sure when I'll get a chance to review it. (I've set a reminder for next week, so I won't forget about it completely. )

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m0baxter @huonw