Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn fmt changes #964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add yarn fmt changes #964

wants to merge 1 commit into from

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented May 13, 2024

Title says it all !!

@psheth9 psheth9 marked this pull request as ready for review May 13, 2024 17:06
Copy link

Size Change: 0 B

Total Size: 11.5 MB

ℹ️ View Unchanged
Filename Size
dist/stellar-sdk.js 6.37 MB
dist/stellar-sdk.min.js 5.12 MB

compressed-size-action

@psheth9 psheth9 requested a review from Shaptic May 13, 2024 17:07
@sreuland
Copy link

sreuland commented May 13, 2024

the changes here look fine, and can approve, but wanted to ask if adding another script target like 'fmt-check' or 'lint' which then runs es-linting or yarn prettier --check to catch these regressions be worthwhile as part of this scope? and then add that new script target as a pre-step in build target so these would get noticed sooner during any ci flow?

@psheth9
Copy link
Contributor Author

psheth9 commented May 14, 2024

@sreuland Yes thats a great idea !! I have created the separate issue #967 for that. would still like to merge this if everything is looking okay.

@psheth9 psheth9 requested a review from sreuland May 14, 2024 20:16
@Shaptic
Copy link
Contributor

Shaptic commented May 14, 2024

I'll merge this last before releasing so that we don't get screwed by merge conflicts.

@Shaptic
Copy link
Contributor

Shaptic commented May 14, 2024

@sreuland we do this in base here! https://github.com/stellar/js-stellar-base/blob/master/.github/workflows/tests.yml#L42 and can do the same thing here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants