Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execvpe to execute zenity and kdialog #234

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

paulfd
Copy link

@paulfd paulfd commented Oct 16, 2021

This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.

@scheffle
Copy link
Collaborator

@paulfd: Is 'execvpe' available on BSD? We have to make sure it works there too.

@paulfd
Copy link
Author

paulfd commented Oct 20, 2021

I'll check it out, are there any particular version/OS you're targeting?

@paulfd
Copy link
Author

paulfd commented Oct 20, 2021

Apparently it's a problem on FreeBSD so you were right to be wary! If you're OK in principle for the patch I can look into it to find a suitable, portable solution.

@scheffle
Copy link
Collaborator

Sure, a portable solution would be nice! Thanks.

@redtide redtide force-pushed the zenity-kdialog-execvp-1 branch 3 times, most recently from 164ae64 to 2116eac Compare May 16, 2023 07:16
This removes the hard-coding of zenity or kdialog paths. Zenity is preferred still.
@redtide
Copy link

redtide commented May 16, 2023

I rebased the code to a recent commit, left the original execve for BSD and execvpe for Linux, which helps NixOS like distributions to find the KDialog/Zenity paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants