Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assume-404-regex flag #105

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vladertel
Copy link

Add ability to mark server response as 404 when it responds with 200 and "Not found" message

Add ability to mark server response as 404 when it responds with 200 and "Not found" message
@vladertel
Copy link
Author

ohhh, the PR got a little bit large since my IDE autoformatted several files. I hope you don't mind

@stefanoj3
Copy link
Owner

Hey! thanks for the PR, the makefile contains a command to format the code, this should bring the files you changed without wanting to back to normal.

I like the change but I'd appreciate if you took the time to make it more generic

rather than having a flag specific for 404 like

--assume-404-regex "404: page .* was not "

what do you think about changing it so it can be used with any status code?

example

--assume-status-code=404 --assume-regex="404: page .* was not "

@vladertel
Copy link
Author

@stefanoj3 done

@vladertel
Copy link
Author

@stefanoj3 ping. could you also make a new release and update one in homebrew?

@vladertel
Copy link
Author

@stefanoj3 ping

@stefanoj3
Copy link
Owner

Hey, sorry for the late comeback @vladertel in the next days I will review and merge if there are no issues.

Thanks for the time spent on this contribution so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants