New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add assume-404-regex flag #105
base: master
Are you sure you want to change the base?
Conversation
Add ability to mark server response as 404 when it responds with 200 and "Not found" message
ohhh, the PR got a little bit large since my IDE autoformatted several files. I hope you don't mind |
Hey! thanks for the PR, the makefile contains a command to format the code, this should bring the files you changed without wanting to back to normal. I like the change but I'd appreciate if you took the time to make it more generic rather than having a flag specific for 404 like
what do you think about changing it so it can be used with any status code? example
|
fix formatting
7453114
to
27bb414
Compare
@stefanoj3 done |
@stefanoj3 ping. could you also make a new release and update one in homebrew? |
@stefanoj3 ping |
Hey, sorry for the late comeback @vladertel in the next days I will review and merge if there are no issues. Thanks for the time spent on this contribution so far. |
Add ability to mark server response as 404 when it responds with 200 and "Not found" message